Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for helm install #170

Merged
merged 8 commits into from
Feb 7, 2022

Conversation

jfilipcz
Copy link
Contributor

@jfilipcz jfilipcz commented Feb 7, 2022

Add support for:

  • Helm install sub-command
  • Timeout parameter for helm install

What does this PR do?

This PR introduced a new task for the purpose of providing support for helm install command.

How should this be tested?

Run it against inventory simliar to this one:

- object: Helm Repos
  content:
      - name: Install Helm Chart 
        helm:
          name: "ABC"
          timeout: "15m"

Is there a relevant Issue open for this?

N/A

Who would you like to review this?

cc: @redhat-cop/openshift-applier

* Helm install subcommand
* Timeout parameter for helm install
Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner solution is to just replace helm template on line 33(34) and add helm_timeout_option to the parameters - the rest looks the same

@jfilipcz
Copy link
Contributor Author

jfilipcz commented Feb 7, 2022

Definitely, I've replaced helm template with helm install and remove oc apply part as it's no longer needed

@oybed
Copy link
Contributor

oybed commented Feb 7, 2022

ha - no no - we need to support the template action. Sorry, should have been more clear ... replace helm template with helm {{ helm.command }}

@oybed
Copy link
Contributor

oybed commented Feb 7, 2022

Also, to be consistent with other parts of the openshift-applier inventory, use the word action instead of command

@oybed
Copy link
Contributor

oybed commented Feb 7, 2022

@jfilipcz submitted PR against your PR branch to help with the robustness:
jfilipcz#1

@oybed oybed added the enhancement New feature or request label Feb 7, 2022
Updated handling of oc_action to be more robust
@jfilipcz
Copy link
Contributor Author

jfilipcz commented Feb 7, 2022

@jfilipcz submitted PR against your PR branch to help with the robustness: jfilipcz#1

Nice thing, I've merged the PR

Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oybed oybed merged commit e658f7e into redhat-cop:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants