-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support for helm install
#170
Conversation
* Helm install subcommand * Timeout parameter for helm install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaner solution is to just replace helm template
on line 33(34) and add helm_timeout_option
to the parameters - the rest looks the same
Definitely, I've replaced |
ha - no no - we need to support the |
Also, to be consistent with other parts of the |
@jfilipcz submitted PR against your PR branch to help with the robustness: |
Updated handling of oc_action to be more robust
Nice thing, I've merged the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add support for:
What does this PR do?
This PR introduced a new task for the purpose of providing support for
helm install
command.How should this be tested?
Run it against inventory simliar to this one:
Is there a relevant Issue open for this?
N/A
Who would you like to review this?
cc: @redhat-cop/openshift-applier