Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vscode-languageclient@8.1.0 #2474

Closed
testforstephen opened this issue May 27, 2022 · 1 comment · Fixed by #2377
Closed

Support vscode-languageclient@8.1.0 #2474

testforstephen opened this issue May 27, 2022 · 1 comment · Fixed by #2377
Labels
debt dependencies Pull requests that update a dependency file

Comments

@testforstephen
Copy link
Collaborator

Starting from LanguageClient@8.0.1, the BaseLanguageClient.start() has been changed to return a promise instead of Dispose, and onReady() is removed, they're breaking changes to vscode-java.

https://github.com/microsoft/vscode-languageserver-node/blob/release/client/8.0.1/client/src/common/client.ts#L933

We need to make changes to the client code in vscode-java to support the new behavior.

this.languageClient.onReady().then(() => {

@rgrunber
Copy link
Member

Just for reference, we're likely going to need to wait on Theia to support things like TypeHierarchyItem. Currently if we run the extension there, it will fail in the vscode-langaugeclient initialization code. See #2377 .

We can just update that PR when ready.

@rgrunber rgrunber added the dependencies Pull requests that update a dependency file label May 27, 2022
@rgrunber rgrunber added this to the Mid March 2023 milestone Mar 15, 2023
@rgrunber rgrunber changed the title Support vscode-languageclient@8.0.1 Support vscode-languageclient@8.1.0 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants