Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate tsconfig for webview #3009

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

CsCherrYY
Copy link
Contributor

With this PR, we have a basic tsconfig.base.json, two configurations tsconfig.json (for extension) and tsconfig.webview.json (for webview) specifies the source configuration and source directories.

will address the side effects from #2967 , which might cause configuration problems related to tsconfig rule esModuleInterop.

Signed-off-by: Shi Chen <chenshi@microsoft.com>
Copy link
Collaborator

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it makes sense to sperate the config for different source sets.

@jdneo jdneo merged commit 5a16809 into redhat-developer:master Mar 20, 2023
@jdneo jdneo added this to the Early April 2023 milestone Mar 20, 2023
@CsCherrYY CsCherrYY deleted the cs-webview-config branch March 20, 2023 09:09
gayanper pushed a commit to gayanper/vscode-java that referenced this pull request May 27, 2023
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants