Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong/Missing Log Levels in application.properties #315

Closed
Faboli7 opened this issue Oct 26, 2020 · 2 comments
Closed

Wrong/Missing Log Levels in application.properties #315

Faboli7 opened this issue Oct 26, 2020 · 2 comments
Assignees
Milestone

Comments

@Faboli7
Copy link

Faboli7 commented Oct 26, 2020

Hi,

Autocomplete for Log Levels has issues.

For all the log level properties except quarkus.log.category.key.level, the proposed levels are the ones from java.util.logging, which means that setting FATAL, ERROR, WARN, DEBUG or TRACE is detected as an error.

For quarkus.log.category.key.level, two more levels are available: ERROR and DEBUG, but the other ones are missing too.

According to this issue (see quote below), the levels that users are expected to use are the ones from JBoss Log Manager. The JUL ones are there only for compatibility reasons.

As far as the Quarkus documentation goes: it was, in my view, an error (due to overzeal) to document anything other than the Apache levels. Those are the levels we expect users to use and configure. The JUL levels are worthy, perhaps, of a footnote, for cases where older Sun frameworks are used (for example) and the user needs to know how to map those levels on to the Apache ones for the purposes of configuring log categories. But this is one case where what is in the JDK is not really the standard that is used by the majority of developers. Documenting them as if they were serves only to add confusion.

The JBoss Log Manager levels should be added to the autocomplete (or used instead of JUL ones if not possible to combine them) to avoid having the properties marked as errors in VS code.

Thanks in advance.

@angelozerr
Copy link
Contributor

Today LEVEL are hard coded on MicroProfile LS side https://github.com/eclipse/lsp4mp/blob/master/microprofile.ls/org.eclipse.lsp4mp.ls/src/main/resources/org/eclipse/lsp4mp/model/values/quarkus-values-rules.json but it was a bad idea. (This issue is a sample of the limitation).

I had created the issue eclipse/lsp4mp#39 but I need more investigation. The basic idea is that MP JDT should return the list of logger level.

@angelozerr angelozerr self-assigned this Oct 28, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 4, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 4, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 6, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 9, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 10, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 12, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 12, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 12, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 12, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 12, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 16, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 16, 2020
@angelozerr angelozerr added this to the 1.8.0 milestone Nov 16, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 16, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 16, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Nov 16, 2020
angelozerr pushed a commit to eclipse/lsp4mp that referenced this issue Nov 17, 2020
@angelozerr
Copy link
Contributor

Fixed with eclipse/lsp4mp#105 and redhat-developer/quarkus-ls#370

@Faboli7 see the following demos:

LevelDemo

QuarkusLevelDemo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants