Fix Wrong/Missing Log Levels in application.properties#105
Fix Wrong/Missing Log Levels in application.properties#105angelozerr merged 1 commit intoeclipse-lsp4mp:masterfrom
Conversation
|
For Quarkus side please use the PR redhat-developer/quarkus-ls#370 too |
e723eac to
94b8050
Compare
|
This PR gives the capability to manage JUL Level with Spring Boot Metadata "hints" mechanism. The current mechanism uses https://github.com/eclipse/lsp4mp/blob/master/microprofile.ls/org.eclipse.lsp4mp.ls/src/main/resources/org/eclipse/lsp4mp/model/values/quarkus-values-rules.json I removed this file and now Level are managed by the MicroProfile JDT instead by MicroProfile LS. It provides several capabilities:
Here a demo with 1 and 2). To test it create a MicroProfile project with Open Liberty and create the following class: package com.example.demo.resilient;
import java.util.logging.Level;
import org.eclipse.microprofile.config.inject.ConfigProperty;
public class Test {
@ConfigProperty(name="mylog.level")
private Level level;
}and see the follwing demo: |
074efa4 to
c86d291
Compare
datho7561
left a comment
There was a problem hiding this comment.
Looks good. There was just a class that I didn't understand that I think could be documented better.
| package org.eclipse.lsp4mp.commons.metadata; | ||
|
|
||
| /** | ||
| * A provider for a value. |
There was a problem hiding this comment.
I don't understand what this class represents. Specifically, I don't know what parameters represents in relation to providing a value for a property. I think it could be better explained in the Javadoc.
There was a problem hiding this comment.
Yes you are right, I will do that. I used the same concept that Spring Boot metadata https://docs.spring.io/spring-boot/docs/current/reference/html/appendix-configuration-metadata.html#configuration-metadata-hints-attributes
There was a problem hiding this comment.
@datho7561 I have add links to Spring Boot metadata. Please tell me if it's enough.
8e1fa62 to
5871c49
Compare
f7a8775 to
d9813bb
Compare
See redhat-developer/vscode-quarkus#315 Signed-off-by: azerr <azerr@redhat.com>
|
Thanks @datho7561 for your great review! |

See redhat-developer/vscode-quarkus#315
Signed-off-by: azerr azerr@redhat.com