Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Quarkus: Generate a Maven Project" command ID #123

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Change "Quarkus: Generate a Maven Project" command ID #123

merged 1 commit into from
Oct 22, 2019

Conversation

xorye
Copy link
Contributor

@xorye xorye commented Oct 22, 2019

Changes the command id for creating Quarkus projects.
The term "Maven" was removed from the id because the command would also allow the users to create Gradle projects in the future.

Also, this change would be nice because adding the "Create a Quarkus Project" link for the Java extension pack overview page: https://github.com/Microsoft/vscode-java-pack, requires the vscode-quarkus command id for creating Quarkus projects.

Signed-off-by: David Kwon dakwon@redhat.com

@xorye xorye added this to the 1.1.1 milestone Oct 22, 2019
@fbricon
Copy link
Collaborator

fbricon commented Oct 22, 2019

also need to update the welcome page with the proper command id

Signed-off-by: David Kwon <dakwon@redhat.com>
@xorye
Copy link
Contributor Author

xorye commented Oct 22, 2019

fixed

@fbricon fbricon merged commit 29f8092 into redhat-developer:master Oct 22, 2019
@xorye xorye changed the title Change create project command name Change "Quarkus: Generate a Maven Project" command ID Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants