(#2036853) Fix unit table overflow by mounts, resulting in "Argument list too long" when trying to start a unit #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd-rhel-bot
added
pr/needs-ci
kolyshkin
force-pushed
the
systemd-e2big
branch
from
a546223
to
db8d26b
Compare
Removed, as it uses functionality ( |
|
This pull request introduces 1 alert when merging db8d26b into de7125d - view on LGTM.com new alerts:
|
kolyshkin
force-pushed
the
systemd-e2big
branch
from
db8d26b
to
82a743b
Compare
|
@msekletar @dtardon PTAL |
jamacku
reviewed
Jan 3, 2022
jamacku
changed the title
systemd-rhel-bot
added
tracker/unapproved
kolyshkin
force-pushed
the
systemd-e2big
branch
from
82a743b
to
575904e
Compare
Done, thanks for your review! |
systemd-rhel-bot
added
pr/needs-ci
If we can't process a specific line in /proc/self/mountinfo we should log about it (which we do), but this should not affect other lines, nor further processing of mount units. Let's keep these failures local. Fixes: #10874 Cherry picked from commit ba0d56f. Trivial conflict in src/core/mount.c, function mount_load_proc_self_mountinfo, due to local commit ca634ba. Also, due to the same commit, int k is no longer used and is thus removed. Resolves: #2036853 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
jamacku
changed the title
jamacku
reviewed
Jan 4, 2022
There was a problem hiding this comment.
@kolyshkin I'm sorry, for my confusion, we need a bug for RHEL8 to properly track these changes, I cloned the original bug and updated Resolves in commit.
jamacku
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of systemd/systemd#10980 (commit systemd/systemd@ba0d56f only) to address issues like systemd/systemd#10874. The backport was almost clean, except for
= 0fromint r);int kis no longer used, so I had to remove it.This also backports systemd/systemd#15222 as it helps a lot to figure out what is going on. This is not required and can be removed.This should fix https://bugzilla.redhat.com/show_bug.cgi?id=2028153 (a non-parse-able mount in mountinfo resulted in piling up inactive mount units, up to
MANAGER_MAX_NAMES, after which it becomes impossible to start any units).Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2036853