Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not decode resp3's big number type #123

Closed
synodriver opened this issue Mar 11, 2022 · 4 comments
Closed

Can not decode resp3's big number type #123

synodriver opened this issue Mar 11, 2022 · 4 comments
Assignees

Comments

@synodriver
Copy link

According to the spec, b"(123456\r\n" is a valid big number type, but I just got a ProtocolError, says Protocol error, got "(" as reply type byte, meanwhile, the pure python parser works well.

Step to reproduce:

import hiredis
reader = hiredis.Reader()
reader.feed(b"(123456\r\n")
print(reader.gets())

Maybe it's related to hiredis itself?

@synodriver
Copy link
Author

synodriver commented Mar 11, 2022

By the way, the unittest missed some RESP3 types.

@illia-v
Copy link
Contributor

illia-v commented Mar 19, 2022

Bignum is not supported by the latest hiredis release (1.0.2) that is vendored by hiredis-py currently, it is supported by its master branch though.

@chayim
Copy link
Contributor

chayim commented Jan 30, 2023

@dvora-h here too

@chayim
Copy link
Contributor

chayim commented Jun 5, 2023

IMHO we can close this. vendored hiredis 1.1.0, and it is in this release, and released in multiple versions.

@chayim chayim closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants