Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #1359 to improve Friendly Error Stack performance #1361

Closed
aivopaas opened this issue May 31, 2021 · 0 comments · Fixed by #1359
Closed

PR #1359 to improve Friendly Error Stack performance #1361

aivopaas opened this issue May 31, 2021 · 0 comments · Fixed by #1359

Comments

@aivopaas
Copy link
Contributor

aivopaas commented May 31, 2021 •
edited

I noticed that when showFriendlyErrorStack=true is set, the Error stack is always serialized, even when it's not needed. By just grabbing the reference to the error, and only doing .stack when the stack is actually needed, we save a lot of CPU cycles so that it might even be worth to have friendly stack traces enabled for production.

The related PR: #1359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: Serialize error stack only when needed aivopaas/ioredis
1 participant
@aivopaas