Test failures on master

[tonit]

Is that expected (due to some refactoring) ??
Running "mvn clean test" with a off-the-shelve Redis 2.0.2 installation:

Results :

Failed tests:
bgsave(redis.clients.jedis.tests.commands.ControlCommandsTest)

Tests in error:
persist(redis.clients.jedis.tests.commands.AllKindOfValuesCommandsTest)
lpushx(redis.clients.jedis.tests.commands.ListCommandsTest)
rpushx(redis.clients.jedis.tests.commands.ListCommandsTest)
linsert(redis.clients.jedis.tests.commands.ListCommandsTest)
trySharding(redis.clients.jedis.tests.ShardedJedisTest)
tryShardingWithMurmure(redis.clients.jedis.tests.ShardedJedisTest)
watch(redis.clients.jedis.tests.commands.TransactionCommandsTest)
unwatch(redis.clients.jedis.tests.commands.TransactionCommandsTest)
strlen(redis.clients.jedis.tests.commands.StringValuesCommandsTest)

Tests run: 151, Failures: 1, Errors: 9, Skipped: 0

[xetorthio]

This is not expected at all. The master branch in Jedis is always stable.
Have in mind that Jedis is always developed agains the latest changes in the master branch, so probably you don't have the latest Redis, which makes these tests to fail.

[tonit]

okay, makes sense. Running Tests against Redis Master:
Results :

Tests in error:
trySharding(redis.clients.jedis.tests.ShardedJedisTest)
tryShardingWithMurmure(redis.clients.jedis.tests.ShardedJedisTest)

Tests run: 151, Failures: 0, Errors: 2, Skipped: 0

[xetorthio]

Are you running the tests against two instances of Redis? You should run 2 instances, one with the redis.conf and the other one with redis2.conf
It is the same configuration but different port, so Jedis can test sharding.
Will add this to the README ASAP!

[tonit]

Mhh okay, this makes sense. How about separating unit tests (run automatically, against a redis mock) and optional (profile based) integration tests (where you need certain dbs set up)..Just a suggestion because "mvn clean install" is usually not expected to need manual software set up. I agree you have the tests, just don't mix them up. Just my idea. At least document that somewhere ;)

[xetorthio]

Yes... documentation is missing and I feel bad about that, so I will do it ASAP (which means later this week).
About a mock... I don't know. I think more than 90% of the tests require Redis to be able to run. Probably there is a way to run redis from maven before the tests. That should be enough. I will add the doc and than try to do that.

[tonit]

ok, tests - if you know what to set up before - work.

[xetorthio]

Sorry about that. Just added that info to a new "I want to contribute!" section on the main page. Feel free to add any missing information. Thanks again!