Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Boolean methods should return boolean values #55

Closed
hamsterready opened this issue Nov 29, 2010 · 5 comments
Closed

Comments

@hamsterready
Copy link
Contributor

Hi,

I think boolean methods like exists() or sismember() should return boolean value instead of Integer.

It would be simpler.

@xetorthio
Copy link
Contributor

Probably we could do that.
Not sure about commands like hset, etc. where true/false is not semantically equivalent to the 0/1 used in those cases.

@hamsterready
Copy link
Contributor Author

Yup, I quickly run through commands reference and found these three:

  • EXISTS
  • SISMEMBER
  • HEXISTS

All with test semantic ("test if" or "test for") - seems to be good candidates for boolean return.

@xetorthio
Copy link
Contributor

perfect! I will go ahead and do this tonight so it'll be available in the final 1.5.0

@xetorthio
Copy link
Contributor

pushed to master!

@hamsterready
Copy link
Contributor Author

Thank you sir, will try to upgrade to 1.5.0 (as my apps are using 1.3.2-SNAPSHOT) at the moment.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants