support for upcoming Redis 2.2

[costin]

Hi,

As Redis 2.2 is approaching RC phase, it would be nice to get support for the new commands in Jedis. I'll gladly test them (once the windows port completes :) ).

[xetorthio]

Sure! I have planned to do it over the weekend! :)

[xetorthio]

done! :) Jedis .1.5.1

[costin]

Hey,

I finally got some time to upgrade to Redis 2.2 (rc2) and Jedis 1.5.1 - here's some quick feedback:

1. getbit/setbit might be better accepting a long as offset instead of a int. This might be the case with the entire API.
2. the new commands (list index, get/set bit etc...) do not seem to be available on the transaction API.
3. brpoplpush returns a String instead of a byte[] on BinaryClient

Otherwise, everything works great - thanks for making this possible!

[xetorthio]

Thanks a lot for the feedback!
I will commit fixed tonight, I just got back from my vacations so now I have time to work on Jedis again! :)
Will keep you updated when changes are made.

[costin]

Hey - any update on this issue? Is there a new branch or snapshot that I have missed?
Thanks!

[xetorthio]

done on master, just forgot to push it to github and let you know :S sorry!

but now it is all pushed and ready for you to play with :)

[costin]

Hey,

Great - just tried the update.

1. the longs are still not exposed on BinaryJedis or on the Transaction API (though the seem to be used on the Client).
2. the transaction API still doesn't have all methods available on it - for example sort& save.
3. indeed this was fixed.

Unfortunately didn't see issue #77 [1] addressed in the master yet.

[1] https://github.com/xetorthio/jedis/issues#issue/77

[xetorthio]

sorry about that. 1 and 2 should be fixed now.
please let me know is something else is missing

[costin]

1. The Binary TX still uses int for get/setBit
2. The sort methods are not available in binary form - the one's I'm looking for are transaction.sort(byte[], SortingParam, byte[] dstKey) and sort(byte[], byte[] dstKey)

[xetorthio]

wooops. missed that. pushed to master.
the only thing missing is: sort(byte[], byte[] dstKey) which doesn't exists anywhere in the code. so will do it today later.

[costin]

I can see the method on BinaryJedis#public Long sort(final byte[] key, final byte[] dstkey).

[xetorthio]

done. sorry about this mess. seems like my brain still thinks I'm on vacations.

[costin]

no worries - everything works now. Any chance of fixing issue #77 (binary pubsub) this week?

[xetorthio]

sure, will do it over this weekend. so expect a new version of Jedis on Monday.