Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vector Similarity #1785

Merged
merged 23 commits into from
Mar 31, 2022
Merged

Support Vector Similarity #1785

merged 23 commits into from
Mar 31, 2022

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Dec 15, 2021

Description

For more information: https://oss.redis.com/redisearch/master/Vectors/#vector_fields

fix #2048

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@lgtm-com
Copy link

lgtm-com bot commented Dec 15, 2021

This pull request introduces 1 alert when merging 5edb140 into 72072f6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@gkorland gkorland requested a review from leibale January 2, 2022 22:42
@lgtm-com
Copy link

lgtm-com bot commented Jan 3, 2022

This pull request introduces 1 alert when merging 2e1dbea into 2203be5 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 8, 2022

This pull request introduces 1 alert when merging c66abd8 into f79e14c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 8, 2022

This pull request introduces 1 alert when merging 76fd70d into f79e14c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@Avital-Fine Avital-Fine changed the title Params support for search Support Vector Similarity Mar 8, 2022
@lgtm-com
Copy link

lgtm-com bot commented Mar 8, 2022

This pull request introduces 1 alert when merging 2dad1bb into f79e14c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@chayim
Copy link
Contributor

chayim commented Mar 30, 2022

CC @DvirDukhan

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #1785 (7ff55a5) into master (33a3f3f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1785   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files         387      387           
  Lines        3516     3516           
  Branches      420      423    +3     
=======================================
  Hits         3349     3349           
  Misses         83       83           
  Partials       84       84           
Impacted Files Coverage Δ
packages/search/lib/commands/AGGREGATE.ts 100.00% <100.00%> (ø)
packages/search/lib/commands/PROFILE_SEARCH.ts 100.00% <100.00%> (ø)
packages/search/lib/commands/SEARCH.ts 92.30% <100.00%> (-1.03%) ⬇️
packages/search/lib/commands/SPELLCHECK.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a3f3f...7ff55a5. Read the comment docs.

@leibale leibale merged commit 4683e96 into master Mar 31, 2022
@leibale leibale deleted the params_support_for_search branch July 18, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dialect support for RediSearch queries
4 participants