Fix invalidations push handler in RESP3

redis · Jun 19, 2024 · 2a9f95d · 2a9f95d
1 parent c518bb4
commit 2a9f95d
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/redis/_parsers/resp3.py b/redis/_parsers/resp3.py
@@ -15,7 +15,7 @@ class _RESP3Parser(_RESPBase):
     def __init__(self, socket_read_size):
         super().__init__(socket_read_size)
         self.pubsub_push_handler_func = self.handle_pubsub_push_response
-        self.invalidations_push_handler_func = None
+        self.invalidation_push_handler_func = None
 
     def handle_pubsub_push_response(self, response):
         logger = getLogger("push_response")
@@ -129,7 +129,10 @@ def _read_response(self, disable_decoding=False, push_request=False):
 
     def handle_push_response(self, response, disable_decoding, push_request):
         if response[0] in _INVALIDATION_MESSAGE:
-            res = self.invalidation_push_handler_func(response)
+            if self.invalidation_push_handler_func:
+                res = self.invalidation_push_handler_func(response)
+            else:
+                res = None
         else:
             res = self.pubsub_push_handler_func(response)
         if not push_request:
@@ -142,15 +145,15 @@ def handle_push_response(self, response, disable_decoding, push_request):
     def set_pubsub_push_handler(self, pubsub_push_handler_func):
         self.pubsub_push_handler_func = pubsub_push_handler_func
 
-    def set_invalidation_push_handler(self, invalidations_push_handler_func):
-        self.invalidation_push_handler_func = invalidations_push_handler_func
+    def set_invalidation_push_handler(self, invalidation_push_handler_func):
+        self.invalidation_push_handler_func = invalidation_push_handler_func
 
 
 class _AsyncRESP3Parser(_AsyncRESPBase):
     def __init__(self, socket_read_size):
         super().__init__(socket_read_size)
         self.pubsub_push_handler_func = self.handle_pubsub_push_response
-        self.invalidations_push_handler_func = None
+        self.invalidation_push_handler_func = None
 
     def handle_pubsub_push_response(self, response):
         logger = getLogger("push_response")
@@ -273,7 +276,10 @@ async def _read_response(
 
     async def handle_push_response(self, response, disable_decoding, push_request):
         if response[0] in _INVALIDATION_MESSAGE:
-            res = self.invalidation_push_handler_func(response)
+            if self.invalidation_push_handler_func:
+                res = self.invalidation_push_handler_func(response)
+            else:
+                res = None
         else:
             res = self.pubsub_push_handler_func(response)
         if not push_request:
@@ -286,5 +292,5 @@ async def handle_push_response(self, response, disable_decoding, push_request):
     def set_pubsub_push_handler(self, pubsub_push_handler_func):
         self.pubsub_push_handler_func = pubsub_push_handler_func
 
-    def set_invalidation_push_handler(self, invalidations_push_handler_func):
-        self.invalidation_push_handler_func = invalidations_push_handler_func
+    def set_invalidation_push_handler(self, invalidation_push_handler_func):
+        self.invalidation_push_handler_func = invalidation_push_handler_func