Merged new sentinel commands from #834 #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks you @otherpirate for the contribution!
The tests ensure that the function is called. Nothing more since we do not currently have enough testing support for sentinel
chayim
changed the title
|
Thank you @otherpirate for the initial work on this in #834! |
Andrew-Chen-Wang
added a commit
to aio-libs-abandoned/aioredis-py
that referenced
this pull request
Oct 8, 2021
Merged new sentinel commands from redis/redis-py#834 (redis/redis-py#1550) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks you @otherpirate for the contribution!### Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
closes #834