Adding Sentinel Commands #834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andymccurdy Could you please review this PR? |
|
There are already sentinel commands in https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L792 |
|
What do you think @andymccurdy ? Should I take @lalinsky suggestion? |
|
This pull request is marked stale. It will be closed in 30 days if it is not updated. |
|
This pull request is marked stale. It will be closed in 30 days if it is not updated. |
|
@otherpirate Thanks for the contribution. This is great! I'd like to get it in right after this pr if that's alright with you. Alternatively if this is no longer active, I'll progress with it. Please let me know! |
4 tasks
chayim
added a commit
that referenced
this pull request
Aug 29, 2021
* Merged new sentinel commands from #835 Thanks you @otherpirate for the contribution! * Added an execute wrapper and tests. The tests ensure that the function is called. Nothing more since we do not currently have enough testing support for sentinel
Andrew-Chen-Wang
added a commit
to aio-libs-abandoned/aioredis-py
that referenced
this pull request
Oct 8, 2021
Merged new sentinel commands from redis/redis-py#834 (redis/redis-py#1550) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentinel API commands