Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Sentinel, and SSL like other classes #1671

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

terencehonles
Copy link
Contributor

@terencehonles terencehonles commented Nov 8, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Now that Sentinel needs to be used specifically instead of via Redis, this change exports the class at the top level like the Redis client is, and also allows the shorthand of ssl=True to set the connection class to the SentinelManagedSSLConnection.

Now that `Sentinel` needs to be used specifically instead of via
`Redis`, this change exports the class at the top level like the `Redis`
client is, and also allows the shorthand of `ssl=True` to set the
connection class to the `SentinelManagedSSLConnection`.
@terencehonles
Copy link
Contributor Author

Now that Sentinel needs to be used specifically instead of via Redis, this change exports the class at the top level like the Redis client is

The export may not be the issue I'm actually trying to fix. It looks like the project I'm contributing to does import Sentinel from the full path. The ssl change is complimentary to #1419, and I can back out the re-export if needed. I'm going to continue trying to track down why the code I'm looking at is breaking with the more recent changes.

@chayim chayim added the bug Bug label Nov 8, 2021
@chayim
Copy link
Contributor

chayim commented Nov 8, 2021

Thanks @terencehonles I fully agree, we should be exposing this. I hope it fixes your bug. Thank you so much for the contribution!

@chayim chayim changed the title export Sentinel at the top level and expose SSL the same way as Redis Export Sentinel, and SSL like other classes Nov 8, 2021
@chayim chayim merged commit fea7b85 into redis:master Nov 8, 2021
@terencehonles terencehonles deleted the update-sentinel branch November 9, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants