Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to make pip install copy-pastable on zsh #2584

merged 1 commit into from Feb 19, 2023


Copy link

@uglide uglide commented Feb 8, 2023

Make pip install redis[hiredis] copy-pastable on zsh

Fix #2445

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Make pip install redis[hiredis] copy-pastable on zsh

Fix #2445
@uglide uglide added the maintenance Maintenance (CI, Releases, etc) label Feb 8, 2023
@chayim chayim changed the title Update README Update README to make pip install copy-pastable on zsh Feb 8, 2023
Copy link

Codecov Report

Base: 92.28% // Head: 92.28% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1af47cc) compared to base (5cb5712).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2584   +/-   ##
  Coverage   92.28%   92.28%           
  Files         115      115           
  Lines       29736    29736           
+ Hits        27442    27443    +1     
+ Misses       2294     2293    -1     
Impacted Files Coverage Δ
tests/test_asyncio/ 98.29% <0.00%> (-0.35%) ⬇️
tests/ 96.97% <0.00%> (+0.10%) ⬆️
tests/test_asyncio/ 99.53% <0.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim merged commit 6c708c2 into master Feb 19, 2023
40 checks passed
@chayim chayim deleted the update-readme branch February 19, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
maintenance Maintenance (CI, Releases, etc)
None yet

Successfully merging this pull request may close these issues.

Unable to install with hiredis option
4 participants