Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAXAGE support to CLIENT KILL #502

Closed
rueian opened this issue Mar 17, 2024 · 0 comments · Fixed by #504
Closed

Add MAXAGE support to CLIENT KILL #502

rueian opened this issue Mar 17, 2024 · 0 comments · Fixed by #504
Labels
feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rueian
Copy link
Collaborator

rueian commented Mar 17, 2024

Ref: redis/go-redis#2920

Suggested change:

Add a MAXAGE block to the end of:

"CLIENT KILL": {
"summary": "Kill the connection of a client",
"complexity": "O(N) where N is the number of client connections",
"arguments": [
{
"name": "ip:port",
"type": "string",
"optional": true
},
{
"command": "ID",
"name": "client-id",
"type": "integer",
"optional": true
},
{
"command": "TYPE",
"type": "enum",
"enum": [
"NORMAL",
"MASTER",
"REPLICA",
"PUBSUB"
],
"optional": true
},
{
"command": "USER",
"name": "username",
"type": "string",
"optional": true
},
{
"command": "ADDR",
"name": "ip:port",
"type": "string",
"optional": true
},
{
"command": "LADDR",
"name": "ip:port",
"type": "string",
"optional": true
},
{
"command": "SKIPME",
"type": "enum",
"enum": [
"YES",
"NO"
],
"optional": true
}

and then run go generate


The NOVALUES block should look like:

      {
        "name": "MAXAGE",
        "type": "integer",
        "token": "MAXAGE",
        "optional": true
      }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant