Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom style guide in README #664

Open
lorenzwalthert opened this issue Apr 5, 2024 · 3 comments
Open

custom style guide in README #664

lorenzwalthert opened this issue Apr 5, 2024 · 3 comments

Comments

@lorenzwalthert
Copy link
Contributor

lorenzwalthert commented Apr 5, 2024

In your README, you have a detailed recommendation for how to not replace = with <- that I realise is only partly correct. It may fail when the {styler} cache is active and transformer dropping is not properly implemented. To my knowledge, a better implementation can be found in the R Polars Project posted here. I am not sure what to do about this but I wanted to bring it to your awareness that the suggested approach may be not working correctly.

Once working correctly (currently not), you could also use https://github.com/Robinlovelace/styler.equals.

@lorenzwalthert
Copy link
Contributor Author

{styler.equals} seems to be a good choice now, maybe once it's on CRAN, we can update the docs here. cc: @Robinlovelace

@Robinlovelace
Copy link

OK awesome, happy to contribute, would that be useful? Thanks so much for all recent activity on this Lorenz!

Robinlovelace added a commit to Robinlovelace/languageserver that referenced this issue Apr 29, 2024
Robinlovelace added a commit to Robinlovelace/styler.equals that referenced this issue Apr 29, 2024
@Robinlovelace
Copy link

Follow-up question: I've had a read of this part of the README and have added a .Rprofile to a project as per commit above.

However, VS Code still highlights = as being typos:

image

Am I missing something? And is it possible to set the linting rules to come from {styler.equals} in the .lintr file, e.g. https://github.com/REditorSupport/languageserver/blob/master/.lintr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants