Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cogniterra #1

Open
OrifjonOlimjonov opened this issue Dec 16, 2023 · 13 comments
Open

Cogniterra #1

OrifjonOlimjonov opened this issue Dec 16, 2023 · 13 comments

Comments

@OrifjonOlimjonov
Copy link
Contributor

Is there the Cogniterra editing link?

@RedJocker
Copy link
Owner

no, not yet

@RedJocker
Copy link
Owner

created cogniterra link and added images for first 2 stages.
invitation link is on trello card for the project.
But for stage descriptions changes make a comment about the desired change in some issue and make a pull request for it here.
Don't just change there because I'll be doing copy and paste from all source code for a given stage description from github to cogniterra and possibly overwrite some edit if you just edit on cogniterra. Also github stage descriptions should be always on most recent version.

@OrifjonOlimjonov
Copy link
Contributor Author

created cogniterra link and added images for first 2 stages. invitation link is on trello card for the project. But for stage descriptions changes make a comment about the desired change in some issue and make a pull request for it here. Don't just change there because I'll be doing copy and paste from all source code for a given stage description from github to cogniterra and possibly overwrite some edit if you just edit on cogniterra. Also github stage descriptions should be always on most recent version.

should I fork it? or is it possible to send a pull request even if I have cloned it?

@RedJocker
Copy link
Owner

I usually do by forking working on my fork and making the pull request through github. I guess there are other ways, but I know just the basics to make things work.

OrifjonOlimjonov added a commit to OrifjonOlimjonov/BlackboardReview that referenced this issue Dec 18, 2023
OrifjonOlimjonov added a commit to OrifjonOlimjonov/BlackboardReview that referenced this issue Dec 18, 2023
OrifjonOlimjonov added a commit to OrifjonOlimjonov/BlackboardReview that referenced this issue Dec 18, 2023
@OrifjonOlimjonov
Copy link
Contributor Author

I think I need to install a program called Mockoon.

@RedJocker
Copy link
Owner

RedJocker commented Dec 18, 2023

I think I need to install a program called Mockoon.

Yes. Users can have the option to make a backend themselves to do manual testing, but I'm predicting that almost every one will prefer to use something that was prepared by us for that and the way I found that was easier to do that was using this program.
Since you are revising the project it is expected that you assert that the mockoon setup is also working and behaving as expected to make manual testing possible for users.
Our tests do not depend on that, it is just a convenience for users, but they will most probably be using it.

@RedJocker
Copy link
Owner

I have added short descriptions for all stages.
I'm still unsure if pre-requisite sections is complete, if you see something that could be added that is not already an implicit pre-requisite though dependency chains please bring it up.

@RedJocker
Copy link
Owner

RedJocker commented Dec 19, 2023

@OrifjonOlimjonov added images to stage3

@RedJocker
Copy link
Owner

added images to stage4 and stage5.
I believe creation phase is done, but you may propose changes yet in your review.
Please also make sure tests are ok and not missing anything essential.
Besides that is just preparing for publishing.

@OrifjonOlimjonov
Copy link
Contributor Author

bandicam.2023-12-21.21-51-34-666.mp4

I think we should add a test for this case.

@RedJocker
Copy link
Owner

There are several cases for invalid login already, I don't see a special reason to add a test case for untrimmed username. I think that it is even better to leave that as an implementation choice, I didn't allow extra whitespaces on end, but it is sort of annoying because the autocomplete does put an extra whitespace, so maybe an implementation that trims whitespaces would actually be a good idea.

@OrifjonOlimjonov
Copy link
Contributor Author

I have updated Prerequisites. Please check it out. maybe i added an unnecessary topic. I think this project type of Challenging. That's why I didn't add basic UI components.

@RedJocker
Copy link
Owner

Thank you very much for the review, I asked alexadra for this review not only because I think it is a good practice, but also I was thinking this would be a good opportunity for you to improve your skills in writing tests for android track so that you can write better projects and with more autonomy. I know we were rushing a bit and that there were some pressure for you to finish review fast, but I hope it was a good experience anyway.
Keep up the good work, hope to collaborate with you in other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants