-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cogniterra #1
Comments
no, not yet |
created cogniterra link and added images for first 2 stages. |
should I fork it? or is it possible to send a pull request even if I have cloned it? |
I usually do by forking working on my fork and making the pull request through github. I guess there are other ways, but I know just the basics to make things work. |
I think I need to install a program called Mockoon. |
Yes. Users can have the option to make a backend themselves to do manual testing, but I'm predicting that almost every one will prefer to use something that was prepared by us for that and the way I found that was easier to do that was using this program. |
I have added short descriptions for all stages. |
@OrifjonOlimjonov added images to stage3 |
added images to stage4 and stage5. |
bandicam.2023-12-21.21-51-34-666.mp4I think we should add a test for this case. |
There are several cases for invalid login already, I don't see a special reason to add a test case for untrimmed username. I think that it is even better to leave that as an implementation choice, I didn't allow extra whitespaces on end, but it is sort of annoying because the autocomplete does put an extra whitespace, so maybe an implementation that trims whitespaces would actually be a good idea. |
I have updated Prerequisites. Please check it out. maybe i added an unnecessary topic. I think this project type of Challenging. That's why I didn't add basic UI components. |
Thank you very much for the review, I asked alexadra for this review not only because I think it is a good practice, but also I was thinking this would be a good opportunity for you to improve your skills in writing tests for android track so that you can write better projects and with more autonomy. I know we were rushing a bit and that there were some pressure for you to finish review fast, but I hope it was a good experience anyway. |
Is there the Cogniterra editing link?
The text was updated successfully, but these errors were encountered: