Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: describe creating values repo #874

Merged
merged 2 commits into from
Aug 16, 2022
Merged

docs: describe creating values repo #874

merged 2 commits into from
Aug 16, 2022

Conversation

j-zimnowoda
Copy link
Contributor

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

oshah97
oshah97 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@oshah97 oshah97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍 one small suggestion, but it is not necessary.

docs/development.md Show resolved Hide resolved
@j-zimnowoda j-zimnowoda merged commit bdd6022 into main Aug 16, 2022
@j-zimnowoda j-zimnowoda deleted the docs branch August 16, 2022 14:22
Ani1357 pushed a commit that referenced this pull request Oct 25, 2023
docs: describe creating values repo (#874)
82d7c77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morriz Morriz Morriz left review comments

@oshah97 oshah97 oshah97 approved these changes

@staticvoid255 staticvoid255 Awaiting requested review from staticvoid255

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-zimnowoda @Morriz @oshah97