Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline images are not shown in PDF when PDF exporting (master) #23

Merged
merged 8 commits into from
Oct 12, 2020

Conversation

yui-har
Copy link
Collaborator

@yui-har yui-har commented Oct 9, 2020

Gem:rbpdf(https://github.com/naitoh/rbpdf) cannot show image data on S3 objects in PDF. Overriding some processing of Gem:rbpdf to show S3 object in PDF.

@yoshiokaCB
Copy link
Collaborator

Thank you for the pull request.

I checked the pull request.
It looks fine, so I'll merge it in.

@yoshiokaCB yoshiokaCB merged commit 27d716d into redmica:master Oct 12, 2020
@yui-har yui-har deleted the task/34886/master branch October 12, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants