Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

round() on ARM Neon uses wrong rounding mode #71

Closed
mlangerak opened this issue Aug 3, 2023 · 2 comments
Closed

round() on ARM Neon uses wrong rounding mode #71

mlangerak opened this issue Aug 3, 2023 · 2 comments
Assignees
@redorav
Labels
bug

Comments

@mlangerak
Copy link

For ARM Neon, _hlslpp_round_ps is implemented using vrndq_f32 which rounds to zero instead of the expected round to even. Instead, _hlslpp_round_ps should use vrndnq_f32.
@redorav redorav self-assigned this Aug 4, 2023
@redorav redorav added the bug label Aug 4, 2023
@redorav
Copy link
Owner

redorav commented Aug 4, 2023

Hi @mlangerak thanks for your interest and reporting. I'll take a look as soon as I can this evening and fix it asap. Thanks!

@redorav
Copy link
Owner

redorav commented Aug 4, 2023

Fixed via 86bae48 and added unit tests

@redorav redorav closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redorav redorav

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@redorav @mlangerak