Revert "pipe: make read() return when write end is closed" #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops, this was incorrect. The
weak_count
test handles this, and this change causes it to return EOF when any file descriptor is dropped, if there are several.The real cause of the issue I had was because it failed to set
O_CLOEXEC
withfcntl()
, which wasn't clear because it didn't make any system call (since that function wasn't implemented in newlib) and git wasn't checking the return value. That is addressed in https://github.com/redox-os/newlib/pull/40.