Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "pipe: make read() return when write end is closed" #30

Merged
merged 1 commit into from Jul 10, 2017
Merged

Revert "pipe: make read() return when write end is closed" #30

merged 1 commit into from Jul 10, 2017

Conversation

@ids1024
Copy link
Member

@ids1024 ids1024 commented Jul 10, 2017

Oops, this was incorrect. The weak_count test handles this, and this change causes it to return EOF when any file descriptor is dropped, if there are several.

The real cause of the issue I had was because it failed to set O_CLOEXEC with fcntl(), which wasn't clear because it didn't make any system call (since that function wasn't implemented in newlib) and git wasn't checking the return value. That is addressed in redox-os/newlib#40.

This reverts commit 09a6764.
@jackpot51 jackpot51 merged commit 8f6268e into redox-os:master Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants