Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decommission ghosted brokers using the Cluster controller #13132

Closed
joejulian opened this issue Aug 30, 2023 · 0 comments · Fixed by #13298
Closed

Decommission ghosted brokers using the Cluster controller #13132

joejulian opened this issue Aug 30, 2023 · 0 comments · Fixed by #13298
Assignees
Labels
area/k8s kind/enhance New feature or request

Comments

@joejulian
Copy link
Contributor

joejulian commented Aug 30, 2023

Who is this for and what problem do they have today?

When a broker's storage is deleted, it comes back with a new broker id. There's no indication as to why the data is gone or whether it can be recovered. Since the Cluster resource is deprecated and the cloud team would just like to have a method to delete it regardless, the consensus is that we should assume it's not recoverable and decommission the old broker id immediately.

What are the success criteria?

  • Add a flag to enable this dangerous behavior.
  • As soon as there is a broker that is not being served by a pod, decommission it.

Why is solving this problem impactful?

After months of running on GKE, a cluster may have enough ghosted brokers that the cluster will fail to reach quorum. Cloud has tests that cause this behavior artificially and they would like that test to pass.

Additional notes

This is dangerous and shouldn't be used. There are circumstances in which brokers with valid data can be decommissioned and even the potential for all the brokers to be decommissioned.

@joejulian joejulian added kind/enhance New feature or request area/k8s labels Aug 30, 2023
@joejulian joejulian self-assigned this Sep 6, 2023
RafalKorepta added a commit to redpanda-data/redpanda-operator that referenced this issue Jun 19, 2024
Calling decommission in the case of changing Pod annotation might be not
possible if Pod was removed along with its annotation where previous
Redpanda ID was stored. There is dedicated function to handle Ghost
brokers.

Reference

redpanda-data/redpanda#9750

redpanda-data/redpanda#13298
redpanda-data/redpanda#13132

redpanda-data/helm-charts#253
redpanda-data/redpanda#12847
RafalKorepta added a commit to redpanda-data/redpanda-operator that referenced this issue Jun 21, 2024
Calling decommission in the case of changing Pod annotation might be not
possible if Pod was removed along with its annotation where previous
Redpanda ID was stored. There is dedicated function to handle Ghost
brokers.

Reference

redpanda-data/redpanda#9750

redpanda-data/redpanda#13298
redpanda-data/redpanda#13132

redpanda-data/helm-charts#253
redpanda-data/redpanda#12847
RafalKorepta added a commit to redpanda-data/redpanda-operator that referenced this issue Jun 28, 2024
Calling decommission in the case of changing Pod annotation might be not
possible if Pod was removed along with its annotation where previous
Redpanda ID was stored. There is dedicated function to handle Ghost
brokers.

Reference

redpanda-data/redpanda#9750

redpanda-data/redpanda#13298
redpanda-data/redpanda#13132

redpanda-data/helm-charts#253
redpanda-data/redpanda#12847
RafalKorepta added a commit to redpanda-data/redpanda-operator that referenced this issue Jul 2, 2024
Calling decommission in the case of changing Pod annotation might be not
possible if Pod was removed along with its annotation where previous
Redpanda ID was stored. There is dedicated function to handle Ghost
brokers.

Reference

redpanda-data/redpanda#9750

redpanda-data/redpanda#13298
redpanda-data/redpanda#13132

redpanda-data/helm-charts#253
redpanda-data/redpanda#12847
RafalKorepta added a commit to redpanda-data/redpanda-operator that referenced this issue Jul 2, 2024
Calling decommission in the case of changing Pod annotation might be not
possible if Pod was removed along with its annotation where previous
Redpanda ID was stored. There is dedicated function to handle Ghost
brokers.

Reference

redpanda-data/redpanda#9750

redpanda-data/redpanda#13298
redpanda-data/redpanda#13132

redpanda-data/helm-charts#253
redpanda-data/redpanda#12847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/k8s kind/enhance New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant