Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redpanda-Operator: manage decommission for helm charts #12847

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Redpanda-Operator: manage decommission for helm charts #12847

merged 1 commit into from
Sep 22, 2023

Conversation

alejandroEsc
Copy link
Contributor

@alejandroEsc alejandroEsc commented Aug 16, 2023 •
edited
Loading

Fixes redpanda-data/helm-charts#253

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

Features

  • Allow to move pods into new nodes if needed, and allow down scaling Redpanda custom resource.

@alejandroEsc alejandroEsc self-assigned this Aug 16, 2023
@alejandroEsc alejandroEsc changed the title Ae/decom/conts Redpanda-Operator: manage decommission for helm charts Aug 23, 2023
@alejandroEsc alejandroEsc force-pushed the ae/decom/conts branch 5 times, most recently from c898680 to dbc0b8a Compare August 24, 2023 17:37
@alejandroEsc alejandroEsc marked this pull request as ready for review August 25, 2023 00:04
@alejandroEsc alejandroEsc requested a review from a team as a code owner August 25, 2023 00:04
@alejandroEsc alejandroEsc mentioned this pull request Aug 25, 2023
Merged
@alejandroEsc alejandroEsc force-pushed the ae/decom/conts branch 3 times, most recently from ae0743c to 9bc6d5e Compare August 30, 2023 13:41
RafalKorepta
RafalKorepta reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't finish.

src/go/k8s/Dockerfile Show resolved Hide resolved
src/go/k8s/Dockerfile Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go Outdated Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go Outdated Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller_tests.go Outdated Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go Outdated Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go Outdated Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go Outdated Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go Outdated Show resolved Hide resolved
@alejandroEsc alejandroEsc force-pushed the ae/decom/conts branch 3 times, most recently from 4ed9875 to 069fdf9 Compare August 31, 2023 13:41
@alejandroEsc alejandroEsc force-pushed the ae/decom/conts branch 4 times, most recently from 21e1af1 to 87d34f7 Compare September 8, 2023 14:59
@RafalKorepta RafalKorepta mentioned this pull request Sep 11, 2023
Merged
@alejandroEsc alejandroEsc force-pushed the ae/decom/conts branch 2 times, most recently from 990ad92 to 91ee0ef Compare September 11, 2023 20:02
@RafalKorepta RafalKorepta mentioned this pull request Sep 12, 2023
Merged
@alejandroEsc alejandroEsc force-pushed the ae/decom/conts branch 4 times, most recently from f479460 to bd13e73 Compare September 14, 2023 17:11
RafalKorepta
RafalKorepta reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left couple questions

src/go/k8s/config/rbac/bases/operator/kustomization.yaml Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_controller_utils.go Outdated Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_node_pvc_controller.go Outdated Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_node_pvc_controller.go Outdated Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_node_pvc_controller.go Show resolved Hide resolved
src/go/k8s/kuttl-v2-test.yaml Show resolved Hide resolved
src/go/k8s/tests/e2e-v2/node-deleted/00-create-redpanda.yaml Show resolved Hide resolved
src/go/k8s/tests/e2e-v2/node-deleted/03-assert.yaml Show resolved Hide resolved
src/go/k8s/controllers/redpanda/redpanda_controller_utils.go Outdated Show resolved Hide resolved
src/go/k8s/config/e2e-v2-tests/kustomization.yaml Outdated Show resolved Hide resolved
RafalKorepta
RafalKorepta previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RafalKorepta
RafalKorepta previously approved these changes Sep 22, 2023
View reviewed changes
@alejandroEsc
Copy link
Contributor Author

Merging, remainder of tests have nothing to do with the changes being committed here. There is no need for the clang tests or to wait for them as they will not be triggered anyway.

@alejandroEsc alejandroEsc merged commit b580d9a into redpanda-data:dev Sep 22, 2023
27 checks passed
@alejandroEsc alejandroEsc deleted the ae/decom/conts branch September 22, 2023 20:21
@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich vbotbuildovich mentioned this pull request Sep 22, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Merged
RafalKorepta added a commit to redpanda-data/redpanda-operator that referenced this pull request Jun 19, 2024
@RafalKorepta
Do not perform Redpanda decommission based on annotation
4a192f9 
Calling decommission in the case of changing Pod annotation might be not
possible if Pod was removed along with its annotation where previous
Redpanda ID was stored. There is dedicated function to handle Ghost
brokers.

Reference

redpanda-data/redpanda#9750

redpanda-data/redpanda#13298
redpanda-data/redpanda#13132

redpanda-data/helm-charts#253
redpanda-data/redpanda#12847
@RafalKorepta RafalKorepta mentioned this pull request Jun 19, 2024
Merged
RafalKorepta added a commit to redpanda-data/redpanda-operator that referenced this pull request Jun 21, 2024
@RafalKorepta
Do not perform Redpanda decommission based on annotation
7c8ba1c 
Calling decommission in the case of changing Pod annotation might be not
possible if Pod was removed along with its annotation where previous
Redpanda ID was stored. There is dedicated function to handle Ghost
brokers.

Reference

redpanda-data/redpanda#9750

redpanda-data/redpanda#13298
redpanda-data/redpanda#13132

redpanda-data/helm-charts#253
redpanda-data/redpanda#12847
RafalKorepta added a commit to redpanda-data/redpanda-operator that referenced this pull request Jun 28, 2024
@RafalKorepta
Do not perform Redpanda decommission based on annotation
d53bda4 
Calling decommission in the case of changing Pod annotation might be not
possible if Pod was removed along with its annotation where previous
Redpanda ID was stored. There is dedicated function to handle Ghost
brokers.

Reference

redpanda-data/redpanda#9750

redpanda-data/redpanda#13298
redpanda-data/redpanda#13132

redpanda-data/helm-charts#253
redpanda-data/redpanda#12847
RafalKorepta added a commit to redpanda-data/redpanda-operator that referenced this pull request Jul 2, 2024
@RafalKorepta
Do not perform Redpanda decommission based on annotation
552ba34 
Calling decommission in the case of changing Pod annotation might be not
possible if Pod was removed along with its annotation where previous
Redpanda ID was stored. There is dedicated function to handle Ghost
brokers.

Reference

redpanda-data/redpanda#9750

redpanda-data/redpanda#13298
redpanda-data/redpanda#13132

redpanda-data/helm-charts#253
redpanda-data/redpanda#12847
RafalKorepta added a commit to redpanda-data/redpanda-operator that referenced this pull request Jul 2, 2024
@RafalKorepta
Do not perform Redpanda decommission based on annotation
1d343d9 
Calling decommission in the case of changing Pod annotation might be not
possible if Pod was removed along with its annotation where previous
Redpanda ID was stored. There is dedicated function to handle Ghost
brokers.

Reference

redpanda-data/redpanda#9750

redpanda-data/redpanda#13298
redpanda-data/redpanda#13132

redpanda-data/helm-charts#253
redpanda-data/redpanda#12847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalKorepta RafalKorepta RafalKorepta approved these changes

Assignees

@alejandroEsc alejandroEsc

Labels
area/k8s k8s/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decommission via Helm
3 participants
@alejandroEsc @vbotbuildovich @RafalKorepta