Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many per-partition metrics when aggregation is turned on #15811

Closed
travisdowns opened this issue Dec 20, 2023 · 1 comment · Fixed by #15966
Closed

Too many per-partition metrics when aggregation is turned on #15811

travisdowns opened this issue Dec 20, 2023 · 1 comment · Fixed by #15966
Assignees
Labels
area/htt kind/bug Something isn't working

Comments

@travisdowns
Copy link
Member

Version & Environment

Redpanda version: 23.2

What went wrong?

When aggregate metrics is turned on, we still have too many metrics which have the partition label, which causes the number of metrics to be very high with high numbers of partitions.

For example, with 23k partitions, we have ~600k metrics on the /metrics endpoint and ~60k on the /public_metrics one.

What should have happened instead?

Fewer metrics.

How to reproduce the issue?

  1. Get the endpoints

Additional information

This will be fixed by additionally aggregating some per-partition metrics.

@travisdowns travisdowns added kind/bug Something isn't working area/htt labels Dec 20, 2023
@travisdowns travisdowns self-assigned this Dec 20, 2023
@travisdowns
Copy link
Member Author

travisdowns added a commit to travisdowns/redpanda that referenced this issue Jan 5, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
consensus object for two metrics: leader_for and reconfiguration
changes in progress.

This change enable aggregation on the partition label for these metrics
if aggregation is turned on.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.
travisdowns added a commit to travisdowns/redpanda that referenced this issue Jan 5, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
partition probe object.

This change enable aggregation on the partition label for almost all
metrics in the partition problem, with only two excluded:

vectorized_cluster_partition_leader_id
vectorized_cluster_partition_under_replicated_replicas

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.
travisdowns added a commit to travisdowns/redpanda that referenced this issue Jan 5, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
tx metrics.

This change enable aggregation on the partition label for almost all
three metrics in this probe.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.
travisdowns added a commit to travisdowns/redpanda that referenced this issue Jan 5, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
partition probe object.

This change enable aggregation on the partition label for almost all
metrics in the partition problem, with only two excluded:

vectorized_cluster_partition_leader_id
vectorized_cluster_partition_under_replicated_replicas

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.
travisdowns added a commit to travisdowns/redpanda that referenced this issue Jan 5, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
tx metrics.

This change enable aggregation on the partition label for almost all
three metrics in this probe.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.
travisdowns added a commit to travisdowns/redpanda that referenced this issue Jan 5, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
partition probe object.

This change enable aggregation on the partition label for almost all
metrics in the partition problem, with only two excluded:

vectorized_cluster_partition_leader_id
vectorized_cluster_partition_under_replicated_replicas

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.
travisdowns added a commit to travisdowns/redpanda that referenced this issue Jan 5, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
tx metrics.

This change enable aggregation on the partition label for almost all
three metrics in this probe.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
consensus object for two metrics: leader_for and reconfiguration
changes in progress.

This change enable aggregation on the partition label for these metrics
if aggregation is turned on.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 04b1535)
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
partition probe object.

This change enable aggregation on the partition label for almost all
metrics in the partition problem, with only two excluded:

vectorized_cluster_partition_leader_id
vectorized_cluster_partition_under_replicated_replicas

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 27e6e2b)
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
tx metrics.

This change enable aggregation on the partition label for almost all
three metrics in this probe.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 65c0a89)
savex pushed a commit that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
consensus object for two metrics: leader_for and reconfiguration
changes in progress.

This change enable aggregation on the partition label for these metrics
if aggregation is turned on.

Issue #15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 04b1535)
savex pushed a commit that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
partition probe object.

This change enable aggregation on the partition label for almost all
metrics in the partition problem, with only two excluded:

vectorized_cluster_partition_leader_id
vectorized_cluster_partition_under_replicated_replicas

Issue #15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 27e6e2b)
savex pushed a commit that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
tx metrics.

This change enable aggregation on the partition label for almost all
three metrics in this probe.

Issue #15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 65c0a89)
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
consensus object for two metrics: leader_for and reconfiguration
changes in progress.

This change enable aggregation on the partition label for these metrics
if aggregation is turned on.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 04b1535)
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
partition probe object.

This change enable aggregation on the partition label for almost all
metrics in the partition problem, with only two excluded:

vectorized_cluster_partition_leader_id
vectorized_cluster_partition_under_replicated_replicas

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 27e6e2b)
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
tx metrics.

This change enable aggregation on the partition label for almost all
three metrics in this probe.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 65c0a89)
andrewhsu pushed a commit to andrewhsu/redpanda that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
consensus object for two metrics: leader_for and reconfiguration
changes in progress.

This change enable aggregation on the partition label for these metrics
if aggregation is turned on.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.
andrewhsu pushed a commit to andrewhsu/redpanda that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
partition probe object.

This change enable aggregation on the partition label for almost all
metrics in the partition problem, with only two excluded:

vectorized_cluster_partition_leader_id
vectorized_cluster_partition_under_replicated_replicas

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.
andrewhsu pushed a commit to andrewhsu/redpanda that referenced this issue Jan 12, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
tx metrics.

This change enable aggregation on the partition label for almost all
three metrics in this probe.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Jan 15, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
consensus object for two metrics: leader_for and reconfiguration
changes in progress.

This change enable aggregation on the partition label for these metrics
if aggregation is turned on.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 04b1535)
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Jan 15, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
partition probe object.

This change enable aggregation on the partition label for almost all
metrics in the partition problem, with only two excluded:

vectorized_cluster_partition_leader_id
vectorized_cluster_partition_under_replicated_replicas

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 27e6e2b)
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Jan 15, 2024
When metrics aggregation is turned on, we want to aggregate away the
partition labels on most metrics: this wasn't occurring in the
tx metrics.

This change enable aggregation on the partition label for almost all
three metrics in this probe.

Issue redpanda-data#15811.
Issue redpanda-data/core-internal#677.

(cherry picked from commit 65c0a89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/htt kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant