Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: missing new line in generated script in rpk redpanda tune #16064

Closed
r-vasquez opened this issue Jan 11, 2024 · 0 comments · Fixed by #16576
Closed

rpk: missing new line in generated script in rpk redpanda tune #16064

r-vasquez opened this issue Jan 11, 2024 · 0 comments · Fixed by #16576
Labels
area/rpk good first issue Good for newcomers kind/bug Something isn't working

Comments

@r-vasquez
Copy link
Contributor

Version & Environment

Redpanda version: (use rpk version):

Version:     v23.3.1
Git ref:     ce417018bf
Build date:  2023-12-22T15:50:55Z
OS/Arch:     linux/amd64
Go version:  go1.21.3

What went wrong?

When generating a tunning script using rpk redpanda tune all --output-script we get:

$ rpk redpanda tune all --output-script /tmp/tune-all-script
$ cat /tmp/tune-all-script
#!/bin/bash

# Redpanda Tuning Script
# ----------------------------------
# This file was autogenerated by RPK

truncate -s 1000000000 /var/lib/redpanda/data/ballastecho 'performance' > /sys/devices/system/cpu/cpufreq/policy0/scaling_governor
echo 'performance' > /sys/devices/system/cpu/cpufreq/policy1/scaling_governor
echo 'performance' > /sys/devices/system/cpu/cpufreq/policy2/scaling_governor 

There is a missing newline in the line that contains truncate:

truncate -s 1000000000 /var/lib/redpanda/data/ballastecho 'performance' > /sys/devices/system/cpu/cpufreq/policy0/scaling_governor

What should have happened instead?

Each command should be in a separate line.

How to reproduce the issue?

  1. rpk redpanda mode prod
  2. rpk redpanda tune all --output-script /tmp/tune-all-script
  3. cat /tmp/tune-all-script

Additional information

Please attach any relevant logs, backtraces, or metric charts.

@r-vasquez r-vasquez added kind/bug Something isn't working good first issue Good for newcomers area/rpk labels Jan 11, 2024
r-vasquez added a commit to r-vasquez/redpanda that referenced this issue Feb 16, 2024
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Feb 16, 2024
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Feb 16, 2024
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Feb 16, 2024
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this issue Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant