rpk: Improve tuner output script #16576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the user provides a file and does not exists: create it. (new) - If it exists, write on it. (current behavior)
gene-redpanda
previously approved these changes
Feb 12, 2024
gene-redpanda
force-pushed
the
improve-output-script
branch
from
e568075
to
6e3716e
Compare
c4milo
previously approved these changes
Feb 13, 2024
c4milo
approved these changes
Feb 16, 2024
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
Fixes #16552
Fixes #16064
Backports Required
Release Notes
Bug Fixes
rpk tune --output-script: Add a missing new line in the ballast file tuner when using the--output-scriptflagImprovements
rpk tune --output-script: rpk now creates a file for you if the provided file does not exist.