-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot build on ubuntu 20.04 #2760
Comments
I attempted to build on 21.10 (with changes from the branch I reference above) and it required some tweaks to the cppkafka build (disable unit tests), as well as bumping up abseil. After this the built failed on the same error 😢
|
to summarize:
|
@ivotron do you have a branch where i can recreate the fragmented_vector issue? that one will be easy to fix |
@dotnwat any luck? |
I think we need to add these to const_iterator& operator-=(ssize_t n) {
_index -= n;
return *this;
}
const_iterator& operator--() {
--_index;
return *this;
} |
This appears to be addressed in rapidjson@main but they haven't had an official release for many years. it seems we may want to update to recent sha1 |
does schema registry need to be part of the main build? could it be removed from the build until there is a fix? |
@unicomp21 i think it will be easier to fix it schema registry than to exclude it from the build. I should have something out today. |
after merging in #2730 https://github.com/unicomp21/redpanda/commits/struggle-redpanda-build i get the following build error(s) https://gist.github.com/unicomp21/7385a81ba19d7e64535028d210e5b04f |
@VadimPlh and @graphcareful ^^ |
@unicomp21 you might simply try repeating the build step to see if it resolves. the v8 build has some internal issues that pop up occasionally. our next step is to get this into a docker container so we have a point of reference. will update this ticket when that's done. |
I saw the same log message for v8 when we had I think the main problem in
|
I think you'll have better luck with Clang 12. |
clang-12 makes it to the end, but output says there were errors https://gist.github.com/unicomp21/b7a4ad6d45a5e0ff3f90e6e0e480334a |
@unicomp21 v8 does not fail build only generates warnings, but looks so wired(Need to fix it). Could you please find 'FAILED' in the whole build log. |
@VadimPlh I put together a build/dockerfile for ya, but the docker build seems to break on that error we're talking about try running this script to repro: my build box is really slow, and I think the FAILED had already scrolled outside the screen buffer, hoping this will get the output we need faster |
[7/123] ccache /usr/bin/clang++ -I/mnt/redpanda/build/deps_build/abseil-prefix/src/abseil -fPIC -fcolor-diagnostics -std=c++20 -O3 -DNDEBUG -fPIC -Wall -Wextra -Wcast-qual -Wconversion -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wfor-loop-analysis -Wformat-security -Wgnu-redeclared-enum -Winfinite-recursion -Wliteral-conversion -Wmissing-declarations -Woverlength-strings -Wpointer-arith -Wself-assign -Wshadow -Wstring-conversion -Wtautological-overlap-compare -Wundef -Wuninitialized -Wunreachable-code -Wunused-comparison -Wunused-local-typedefs -Wunused-result -Wvla -Wwrite-strings -Wno-float-conversion -Wno-implicit-float-conversion -Wno-implicit-int-float-conversion -Wno-implicit-int-conversion -Wno-shorten-64-to-32 -Wno-sign-conversion -DNOMINMAX -std=c++20 -MD -MT absl/flags/CMakeFiles/flags_usage_internal.dir/internal/usage.cc.o -MF absl/flags/CMakeFiles/flags_usage_internal.dir/internal/usage.cc.o.d -o absl/flags/CMakeFiles/flags_usage_internal.dir/internal/usage.cc.o -c /mnt/redpanda/build/deps_build/abseil-prefix/src/abseil/absl/flags/internal/usage.cc [46/85] Performing build step for 'abseil' |
and here is how the build in terminal.sh ends [1745/1745] AR obj/libv8_monolith.a |
hi @unicomp21, the branch for #2730 is now working ok. it runs on a |
Impish (21.10) has clang 12.01 and libstdc++ 11.2.0. |
yeah, it's 11.2.0 as opposed to 11.2.1 but it might work (didn't test myself) |
@ivotron is this expected? Total Test time (real) = 525.48 sec The following tests FAILED: |
i'll double check, but all unit tests were running fine on my end, is this on ubuntu or fedora? |
Fedora 34 in docker
…On Tue, Nov 2, 2021 at 10:23 AM Ivo Jimenez ***@***.***> wrote:
@ivotron <https://github.com/ivotron> is this expected?
Total Test time (real) = 525.48 sec
The following tests FAILED: 22 - coproc_fixture_rpunit (Failed) 24 -
storage_single_thread_rpunit (Failed) 38 - partition_moving_test_rpunit
(Failed) Errors while running CTest
i'll double check, but all unit tests were running fine on my end, is this
on ubuntu or fedora?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2760 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEFL7OLKCFUGMEK4FBA67TUJ765PANCNFSM5GSI3OGA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
hmm, i just double checked on a fresh clone on an ubuntu 21.10 host, as well as a fedora:34 host and all works OK. would it be possible to get the full log (as an attachment if it's too big). Do you see any errors related to |
is docker running on the host? everything i've been doing has been in docker. sounds like the repro requires running in docker, like @dotnwat was talking about? if docker is a new thing, just holler, i can help out. here is the tail of my screen buffer on the last build, in docker (fedora 34), on an ubuntu 21.10 host https://gist.github.com/unicomp21/dfb3846b5369e353cbccf7544c37c9ba |
sorry for the confusion; yeah, i'm assuming running in docker on those hosts. This is how I've been running: git clone git@github.com:vectorizedio/redpanda
cd redpanda/
# pull toolchain image
docker pull vectorized/redpanda-toolchain
# set fs.max-aio-nr an appropriate value
sudo sysctl -w fs.aio-max-nr=10485760
# build inside container
docker run --rm -ti --privileged --ipc=host -v $PWD:$PWD -w $PWD vectorized/redpanda-toolchain ./build.sh edit: tweaked instructions to reflect #2730 being merged |
looks like either flush/write is failing. are you low on disk space, perhaps? |
No, over 500GB free. Strange.
…On Wed, Nov 3, 2021 at 12:54 PM Noah Watkins ***@***.***> wrote:
ERROR 2021-11-02 06:30:48,573 [shard 2] assert - Assert failure: (../src/v/storage/segment_appender.cc:495) 'false' Could not dma_write: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > - {no_of_chunks:64, closed:0, fallocation_offset:33554432, committed_offset:32768, bytes_flush_pending:183}
looks like either flush/write is failing. are you low on disk space,
perhaps?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2760 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEFL7K5ZV6PN3AQT37FD4TUKGAQDANCNFSM5GSI3OGA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
I just got a successful build w/ vectorized/redpanda-toolchain container in docker. Yay! Is this identical to what's in the tools image here? If so, then I'm confused, because that Dockerfile is what I ran as manual commands earlier, for fedora:34 |
@unicomp21 would you mind adding a section to the docs on how to build |
@senior7515 absolutely, will do |
closing |
It fails with the following output:
CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:3 (project)
The text was updated successfully, but these errors were encountered: