Serialization for sestar::chunked_fifo
#10408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Added test verifying if all `std::vector`, `ss::chunked_fifo` and `fragmented_vector` Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
chunked-fifo-serialization
branch
from
9961cff
to
e7898a3
Compare
mmaslankaprv
changed the title
sestar::chunked_fifosestar::chunked_fifo
|
Just to confirm my understanding, this really just serializes the values (plus a size header) out and not the struct itself? |
|
Correct! The nice part about this sort of format is that it doesn't tie you into a specific struct on the deserialization end, which gives compatibility if we want to change data structures in places later on. Most of the collections have this same format. |
This was referenced May 10, 2023
vshtokman
added a commit
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added serialization for
ss::chunked_fifoforadlandserdeBackports Required
Release Notes