tests: further action injector fixes #10491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used in action injector in the next commit.
The run() method was calling Admin.ready without handling connection errors. This would be an unhandled exception that caused us to fall out of run() prematurely without waiting for nodes to be ready. Fixes redpanda-data#10364
Previously, exceptions thrown from run() would be ignored. This had two impacts: - We might not have been injecting the failures we thought we were - The end-of-run cluster status check could be skipped, leaving the cluster in an undefined state.
abhijat
reviewed
May 2, 2023
| err_msg='Cluster did not recover after failures') | ||
|
|
||
| def join(self, *args, **kwargs): |
There was a problem hiding this comment.
It used to be recommended not to override join (or anything other than init and run really) in threading.Thread. I cannot find any latest references about it though. It seems like this should work okay.
abhijat
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #10196 weren't working properly, and it wasn't obvious because action injector was not propagating exceptions from its main loop when joined.
Fix the status check on teardown, and make it so that exceptions from ActionInjector.run will propagate to callers of join().
Fixes #10364
Backports Required
Release Notes