Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: ducktape test of rpk -X and rpk profile #11048

Merged
merged 6 commits into from
Jun 6, 2023
Merged

tests: ducktape test of rpk -X and rpk profile #11048

merged 6 commits into from
Jun 6, 2023

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented May 25, 2023 •
edited
Loading

This PR introduces:

  • Ducktape tests for rpk profile.
  • Ducktape tests for rpk cloud login using client credentials.
  • Small refactor of rpk config ducktape test.

Backports Required

  • none - issue does not exist in previous branches

Release Notes

  • none

@r-vasquez r-vasquez force-pushed the test-x-profile branch 3 times, most recently from 2836cfc to 39b5862 Compare May 29, 2023 22:37
@r-vasquez r-vasquez mentioned this pull request May 29, 2023
Closed
1 task
@r-vasquez r-vasquez marked this pull request as ready for review May 29, 2023 22:39
@r-vasquez r-vasquez requested review from twmb and removed request for twmb May 29, 2023 22:39
@r-vasquez
Copy link
Contributor Author

/ci-repeat 4 skip-units dt-repeat=5 tests/rptest/tests/rpk_profile_test.py

@r-vasquez
Copy link
Contributor Author

/ci-repeat 4 skip-units dt-repeat=5 tests/rptest/tests/rpk_cloud_test.py

@r-vasquez r-vasquez force-pushed the test-x-profile branch 2 times, most recently from 5a2e7ea to 6f358b2 Compare May 30, 2023 02:16
@r-vasquez
Copy link
Contributor Author

/ci-repeat 4 skip-units dt-repeat=5 tests/rptest/tests/rpk_profile_test.py

@r-vasquez
Copy link
Contributor Author

/ci-repeat 4 skip-units dt-repeat=5 tests/rptest/tests/rpk_profile_test.py

@r-vasquez
Copy link
Contributor Author

Last force-push change:

  • Cleaning runner rpk.yaml in setUp instead of tearDown

gene-redpanda
gene-redpanda previously approved these changes May 31, 2023
View reviewed changes
@r-vasquez
Copy link
Contributor Author

/ci-repeat 4 skip-units dt-repeat=5 tests/rptest/tests/rpk_profile_test.py

@r-vasquez
Copy link
Contributor Author

r-vasquez commented May 31, 2023 •
edited
Loading

The tests are passing in normal builds but they fail when running with /ci-repeat, I'm unable to reproduce locally even if I repeat the test over and over with DUCKTAPE_REPEAT, I'll come back later to this. Putting this on hold for now.

@r-vasquez r-vasquez force-pushed the test-x-profile branch 3 times, most recently from 41de529 to edd9820 Compare June 2, 2023 21:40
@r-vasquez
rpk: add 'ls' as alias fror profile/auth list
593045d
@r-vasquez
test: replace _some_ flags for -X flags
b3746e5 
The idea is to start replacing some old flags for
the new -X flags, this way we can monitor that we
are not breaking backcompat and we test the new
ones.
@r-vasquez
tests: add the option to redact logs
a0da71e 
We might want to hide some command logs
next commit will use this to hide
rpk cloud login logs.
@r-vasquez
tests: add rpk config utils, refactor cfg test
b253ab0 
This refactors helps to avoid duplication and
introduce config utils that will be used in
the following tests.
@r-vasquez
tests: add rpk profile tests
95f1cfe 
Introduces new rpk/rpk_remote handlers for newly
introduced command 'profile'.

Also add the deletion of the rpk.yaml as part of
the node cleanup process.
@r-vasquez
Copy link
Contributor Author

r-vasquez commented Jun 5, 2023 •
edited
Loading

First run OK ✅ (10 unrelated failures, OFailures are marked as failures) https://buildkite.com/redpanda/redpanda/builds/30625#01888ca5-ccaf-4332-860e-14da7bcb9ae4

@r-vasquez
Copy link
Contributor Author

/ci-repeat 4 skip-units dt-repeat=5 tests/rptest/tests/rpk_profile_test.py

@r-vasquez
Copy link
Contributor Author

image

20 Repeated rpk profile tests: https://buildkite.com/redpanda/redpanda/builds/30635#_

@r-vasquez
tests: add rpk cloud login test
f269f89 
Simple rpk cloud login and logout using credentials
and checking that it writes the token to the
rpk.yaml.
@r-vasquez
Copy link
Contributor Author

Last Force Push changes: Followed the same fix for the rpk cloud login test.

@r-vasquez
Copy link
Contributor Author

Second run OK ✅: https://buildkite.com/redpanda/redpanda/builds/30639# 2 unrelated failures.

@r-vasquez
Copy link
Contributor Author

/ci-repeat 4 skip-units dt-repeat=5 tests/rptest/tests/rpk_cloud_test.py

@r-vasquez
Copy link
Contributor Author

20 rpk cloud login/logout test ✅ https://buildkite.com/redpanda/redpanda/builds/30677#_

image

gene-redpanda
gene-redpanda approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@r-vasquez
Copy link
Contributor Author

Last full build was: https://buildkite.com/redpanda/redpanda/builds/30639 and had 2 unrelated failures

Build Link Issue
https://buildkite.com/redpanda/redpanda/builds/30639#01888da9-d29a-477f-aa1d-91f230f5f5eb/6-5442 #11166
https://buildkite.com/redpanda/redpanda/builds/30639#01888da0-9cde-4159-b585-7a40762d8ecc/6-4625 #11044

@r-vasquez r-vasquez merged commit 90260bc into redpanda-data:dev Jun 6, 2023
@r-vasquez r-vasquez deleted the test-x-profile branch July 19, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gene-redpanda gene-redpanda gene-redpanda approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-vasquez @gene-redpanda