partition_allocator: preserve shards for replicas on original nodes #11077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for preserving the shard when moving replicas to original nodes - we want to choose the shard in partition_allocator itself, not in allocation_strategy.
After one or several reallocations a replica may end up on one of the original nodes. Previously, we chose the shard for this replica anew in this case. This is awkward because the shard could change so the full replica id (i.e. broker_shard) changed even if the reallocation didn't change anything in the grand scheme of things. So this commit makes reallocations preserve the shard of replicas that end up on original nodes. And of course this change makes it easier in the future to let nodes choose shards for the replicas they host themselves.
mmaslankaprv
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After one or several reallocations a replica may end up on one of the original nodes. Previously, we chose the shard for this replica anew in this case. This is awkward because the shard could change so the full replica id (i.e. broker_shard) changed even if the reallocation didn't change anything in the grand scheme of things. So this PR makes reallocations preserve the shard of replicas that end up on original nodes.
And of course this change makes it easier in the future to let nodes choose shards for the replicas they host themselves.
Backports Required
Release Notes