Using node_status_table to determine node unavailability in partition balancer
#11146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
force-pushed
the
partition-balancer-node-status
branch
from
d968578
to
d281b15
Compare
bharathv
previously approved these changes
Jun 1, 2023
mmaslankaprv
force-pushed
the
partition-balancer-node-status
branch
from
d281b15
to
d31c137
Compare
ztlpn
reviewed
Jun 2, 2023
| for (const auto& follower : follower_metrics) { | ||
| auto unavailable_dur = now - follower.last_heartbeat; | ||
| auto node_status = _state.node_status().get_node_status(id); | ||
| // node status is not yet available, wait for it to be updated |
There was a problem hiding this comment.
As discussed on slack, we should cover the case when a remote node didn't respond to pings at all since the current node startup. I guess we should use time when we discovered the node through the members table as last_seen in this case.
There was a problem hiding this comment.
i will open a follow up pr with the changes in node_status subsystem it seems that we also do not clean the status table when node is removed from the cluster
Since `partition_balancer_backend` is going to use the `node_status_table` to recognize unavailable node it has be has an access to it. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
partition-balancer-node-status
branch
2 times, most recently
from
a4bed64
to
b1edff0
Compare
Using `node_status_table` last heartbeat timestamps to determine if a node is unavailable. Previously `partition_balancer_planner` was using follower state coming from the controller raft group. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
partition-balancer-node-status
branch
from
b1edff0
to
a66fccb
Compare
ztlpn
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
node_status_tablelast heartbeat timestamps to determine if anode is unavailable. Previously
partition_balancer_plannerwas usingfollower state coming from the controller raft group.
Fixes: #7218
Backports Required
Release Notes