c/self-test/diskcheck: Avoid large allocations #11173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`diskcheck_opts::request_size` is provided by the user. To avoid very large allocations, split the request size into at most 128KiB chunks, and read/write them via an iovec. Preliminary testing shows very little difference in the performance. Fixes redpanda-data#10305 Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
force-pushed
the
cluster-diskcheck-allocs
branch
from
b4e2227
to
33313e9
Compare
dotnwat
reviewed
Jun 2, 2023
| iov.reserve(_opts.request_size / buf_len); | ||
| for (size_t offset = 0; offset < _opts.request_size; offset += buf_len) { | ||
| size_t len = std::min(_opts.request_size - offset, buf_len); | ||
| iov.push_back(iovec{buf.get(), len}); |
There was a problem hiding this comment.
should we regenerate with new random data here? potentially to avoid making compression more effective?
There was a problem hiding this comment.
There's no compression option in self_test::diskcheck , so i think its cool
|
ping @graphcareful |
graphcareful
approved these changes
Jun 4, 2023
| iov.reserve(_opts.request_size / buf_len); | ||
| for (size_t offset = 0; offset < _opts.request_size; offset += buf_len) { | ||
| size_t len = std::min(_opts.request_size - offset, buf_len); | ||
| iov.push_back(iovec{buf.get(), len}); |
There was a problem hiding this comment.
There's no compression option in self_test::diskcheck , so i think its cool
dotnwat
approved these changes
Jun 5, 2023
|
/backport v23.1.x |
This was referenced Jun 5, 2023
Closed
|
Thanks for this fix, @BenPope! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diskcheck_opts::request_sizeis provided by the user.To avoid very large allocations, split the request size into at most 128KiB chunks, and read/write them via an iovec.
Local testing with a single core:
Fixes #10305
Backports Required
Release Notes
Improvements