tools: import rp-storage-tool
#11223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
added
kind/enhance
7 tasks
This is from commit b101a31927d48e513bec21ad500c048c91e7c192 of https://github.com/jcsp/segment_toy
This was mostly unused and the serialization half was incomplete: retain the deserialization part in a utility file for where it's used to read RecordBatchHeader.
The remaining warnings are from code used in the unstable binary that is unused in the main binary.
This avoids the need for bumping shas.
|
None of the failures are related with the end-of-test scrub (modulo #11232 which is something else) |
dotnwat
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool is used in automated tests and during support.
It is not packaged + shipped with Redpanda, but the redpanda tree is a convenient place to keep it, and makes it easier to keep the tests consuming the latest tool.
The docker test image build is updated to build rp-storage-tool and client-swarm in different stages, with a common
rustimage ancestor: this is aligned with what we do for golang dependencies.A vtools update will need merging about the same time this merges:
A separate PR adds a github action for unit testing PRs that change the tool
Backports Required
Release Notes