Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud_storage: Destroy client_pool probe in stop() #11288

Merged
merged 1 commit into from
Jun 8, 2023
Merged

cloud_storage: Destroy client_pool probe in stop() #11288

merged 1 commit into from
Jun 8, 2023

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Jun 7, 2023

Fixes #11285

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

  • none

@BenPope
cloud_storage: Destroy client_pool probe in stop()
7b579f1 
Fixes redpanda-data#11285

Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope force-pushed the cloud_storage_client_pool_probe branch from 0d97f09 to 7b579f1 Compare June 7, 2023 18:28
@BenPope
Copy link
Member Author

BenPope commented Jun 7, 2023

CI Failures:

VladLazar
VladLazar approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lifetime of this probe is diabolical.

@BenPope
Copy link
Member Author

BenPope commented Jun 8, 2023

The lifetime of this probe is diabolical.

Is it worth doing something about startup? Like adding a client_pool::start()?

@VladLazar
Copy link
Contributor

The lifetime of this probe is diabolical.

Is it worth doing something about startup? Like adding a client_pool::start()?

Start-up should be fine. It's just that threading a probe down via a shared ptr all the way to who knows where doesn't sit well with me.

@piyushredpanda piyushredpanda merged commit 35a0949 into redpanda-data:dev Jun 8, 2023
@VladLazar VladLazar mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladLazar VladLazar VladLazar approved these changes

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
3 participants
@BenPope @VladLazar @piyushredpanda