[cloud_storage] segment_meta_cstore::materialize: revert find to lower_bound

[andijcr]

fix a previous wrong commit.
the proper way to use the _hints vector is with lower_bound, to get an exact match or a close one, to speed up materialize. with just find, most of the call will take the slow path

Backports Required

• none - not a bug fix
• none - this is a backport
• none - issue does not exist in previous branches
• none - papercut/not impactful enough to backport
• v23.1.x
• v22.3.x
• v22.2.x

Release Notes

• none

[dotnwat]

seems like maybe we should have a unit test for the case that caught this issue?

[andijcr]

It's difficult to model since it's just an optimization for faster lookup. I can see if there is a significant time discrepancy, but it would require some code to work as a baseline.

probably it could be easier to expose some internals to the test, maybe via a friend declaration

[andijcr]

https://buildkite.com/redpanda/redpanda/builds/31224#0188b676-8e1f-4c86-a4e5-b7b25913f358
issues are

• CI Failure (Consumed from an unexpected) in SimpleEndToEndTest.test_consumer_interruption #11306
• CI Failure (RpkException - SASL authentication failed) in SchemaRegistryAutoAuthTest.test_schema_id_validation #11203
• CI Failure (Timeout - Failed to start) in MultiTopicAutomaticLeadershipBalancingTest.test_topic_aware_rebalance #11044
• CI Failure (timeout on start) in PartitionMoveInterruption.test_cancellations_interrupted_with_restarts #10497

this one is new:

• CI Failure (rpk consume timeout) in OffsetRetentionTest.test_offset_expiration #11422
  doesn't appear related, waiting for other signals on this

[andijcr]

/ci-repeat 3 dt-repeat=3 tests/rptest/tests/offset_retention_test.py::OffsetRetentionTest.test_offset_expiration

[andijcr]

force push: rebase on dev and ci run

[andijcr]

failure is #11455 and #11182

[andijcr]

/ci-repeat

[andijcr]

https://buildkite.com/redpanda/redpanda/builds/32087#0188fe8b-7fe5-45a0-baa9-3717421e98e1
issues are
#11449
and
new issue fixed by #11733

Doing a ci repeat for the offending test

[andijcr]

/ci-repeat 3 skip-unit dt-repeat=10 tests/rptest/tests/topic_delete_test.py::TopicDeleteCloudStorageTest.topic_delete_unavailable_test
tests/rptest/tests/topic_creation_test.py::CreateTopicUpgradeTest.test_retention_config_on_upgrade_from_v22_2_to_v22_3

[andijcr]

force push: rebase on dev to check for conflicts

[Lazin]

LGTM!

[andijcr]

https://buildkite.com/redpanda/redpanda/builds/32265
issues:
#11362
#11790

and a new one

====================================================================================================
test_id:    rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves.cleanup_policy=compact.delete
status:     FAIL
run time:   2 minutes 25.957 seconds


    TimeoutError('Workload did not complete within 120s: Consumer consumed only 11259 out of 15360 messages')
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 135, in run
    data = self.run_test()
  File "/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 227, in run_test
    return self.test_context.function(self.test)
  File "/usr/local/lib/python3.10/dist-packages/ducktape/mark/_mark.py", line 481, in wrapper
    return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
  File "/root/tests/rptest/services/cluster.py", line 79, in wrapped
    r = f(self, *args, **kwargs)
  File "/root/tests/rptest/utils/mode_checks.py", line 63, in f
    return func(*args, **kwargs)
  File "/root/tests/rptest/tests/cloud_storage_timing_stress_test.py", line 527, in test_cloud_storage_with_partition_moves
    while not self.is_complete():
  File "/root/tests/rptest/tests/cloud_storage_timing_stress_test.py", line 362, in is_complete
    raise TimeoutError(
TimeoutError: Workload did not complete within 120s: Consumer consumed only 11259 out of 15360 messages

repeating this last one

[andijcr]

/ci-repeat 3 release skip-unit dt-repeat=5 tests/rptest/tests/cloud_storage_timing_stress_test.py::CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves

[andijcr]

/ci-repeat 3 release skip-unit dt-repeat=5 tests/rptest/tests/cloud_storage_timing_stress_test.py::CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves