pandaproxy: Support SCRAM-SHA-512 for basic_auth #11425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User credentials provided by basic auth cannot provide a sasl_mechanism. During request authorization, both mechanisms are tried, but the mechanism that succeeds was not propagated in the request_auth_result. This commit propagates the successful mechanism and uses that during the creation of the client when http basic auth is used for requests to Pandaproxy, instead of hardcoding it to SCRAM-SHA-256. Signed-off-by: Ben Pope <ben@redpanda.com>
alejandroEsc
approved these changes
Jun 14, 2023
NyaliaLui
approved these changes
Jun 14, 2023
|
/backport v23.1.x |
|
/backport v22.3.x |
|
/backport v22.2.x |
This was referenced Jun 14, 2023
|
Failed to run cherry-pick command. I executed the commands below: |
RafalKorepta
pushed a commit
to RafalKorepta/helm-charts-1
that referenced
this pull request
Jun 15, 2023
The PR redpanda-data#544 does not pass tests due to bug in Redpanda. The pandaproxy fix will be backported eventually redpanda-data/redpanda#11425, but to unblock the nightly build the test SASL mechanism should be change from `SCRAM-SHA-512` to `SCRAM-SHA-256`.
|
@BenPope: Good job! Linked to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User credentials provided by basic auth cannot provide a sasl_mechanism.
During request authorization, both mechanisms are tried, but the mechanism that succeeds was not propagated in the request_auth_result.
This commit propagates the successful mechanism and uses that during the creation of the client when http basic auth is used for requests to Pandaproxy, instead of hardcoding it to SCRAM-SHA-256.
Backports Required
Release Notes
Bug Fixes
SCRAM-SHA-512forauthentication: http_basic.