Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server side schema id validation: metrics #11534

Closed
wants to merge 3 commits into from
Closed

Server side schema id validation: metrics #11534

wants to merge 3 commits into from

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Jun 19, 2023

Notes to reviewer:

  • I put these in the same PR since I found the latter whilst fixing the former, and they'd just collide anyway.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

  • none

@BenPope
schema_registry: Handle exceptions when validating schema ID.
36a74b7 
Handle exceptional futures from validation; for example, when
the schema registry is misconfigured.

Fixes redpanda-data#11526

Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope
schema_registry: Add a metric for schema ID validation failure
972679a 
Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope added the area/schema-registry Schema Registry service within Redpanda label Jun 19, 2023
@BenPope BenPope self-assigned this Jun 19, 2023
@BenPope BenPope force-pushed the server-side-schema-id-validation-metrics branch from 3872be1 to fdbcdc1 Compare June 19, 2023 17:46
@BenPope
Copy link
Member Author

BenPope commented Jun 20, 2023

CI Failures:

@BenPope BenPope marked this pull request as ready for review June 20, 2023 11:32
@BenPope BenPope mentioned this pull request Jun 20, 2023
Merged
7 tasks
@NyaliaLui NyaliaLui self-requested a review June 20, 2023 15:48
@michael-redpanda
Copy link
Contributor

Is this one cancelled? Does #11559 supersede this one?

@BenPope
Copy link
Member Author

BenPope commented Jun 21, 2023

Closed in favour of #11559

@BenPope BenPope closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyaliaLui NyaliaLui NyaliaLui approved these changes

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda

Assignees

@BenPope BenPope

Labels
area/redpanda area/schema-registry Schema Registry service within Redpanda
Projects
None yet
Milestone
No milestone
3 participants
@BenPope @michael-redpanda @NyaliaLui