[v23.2.x] cloud_storage: Add client address to fetch and log reader config #14952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When shutting down connection due to either the abort source being triggered, or during normal stop, log the peer address at trace level to assist in troubleshooting. (cherry picked from commit 9c74682)
The client address for a connection is added into fetch config. This allows the downstream remote partition code paths to use the client address as an identifier during logging. The client address is optional. (cherry picked from commit 4765c7a)
The log reader config is extended to contain the client address. This allows the remote partition code paths to use the client address while logging, enabling identification of consumers from the kafka layer. (cherry picked from commit bd854a7)
At several points in remote partition such as creating a reader, waiting for units, initializing a cursor, the config is logged. The client address is part of this config so it should now be possible to take a stuck connection and be able to trace its current state somewhat more precisely than solely based on log offsets. (cherry picked from commit a499be7)
(cherry picked from commit c720b5d)
vbotbuildovich
requested review from
dotnwat,
nvartolomei,
BenPope,
andrwng and
VladLazar
andrwng
approved these changes
Nov 14, 2023
dotnwat
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #14821