[v23.2.x] r/consensus: update _last_leader_visible_offset on leader as well #15369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit c755b49) Conflicts: src/v/transform/rpc/tests/transform_rpc_test.cc
Since fetch offset is validated against log end offset we should log this information when consumer is returned out of range error. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 61bcc77)
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 3657bec) Conflicts: src/v/transform/rpc/tests/transform_rpc_test.cc
Previously _last_leader_visible_offset was updated only from info in append_entries requests. This meant that on a leader that was stepping down there was a small window between stepping down and receiving the first append_entries from the new leader, where _last_leader_visible_offset value was bogus. This led offset_out_of_range errors when serving valid fetch requests as a follower. Fix this by updating _last_leader_visible_offset value while we are the leader as well. (cherry picked from commit 434b7fb)
This reproduces the offset_out_of_range bug fixed in the previous commit. (cherry picked from commit 43ba5db)
No change in validation logic. (cherry picked from commit 55da48c) Conflicts: src/v/transform/rpc/tests/transform_rpc_test.cc
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #14620
Backport of PR #15357
Fixes #15173
Fixes #15367