c/topic_table: do not log duplicated lifecycle marker command #15407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/dt |
|
new failures in https://buildkite.com/redpanda/redpanda/builds/42618#018c5f37-fac9-4baa-95e3-1ea007e87cdb: new failures in https://buildkite.com/redpanda/redpanda/builds/42618#018c5f10-2446-4630-94d8-ab10b32f43da: |
|
/ci-repeat 1 |
ztlpn
previously approved these changes
Dec 15, 2023
It is possible that the drop topic lifecycle marker replicate request would timeout. In this case requester has no other option than to retry dropping lifecycle marker. Logic in `cluster::topic_table` is idempotent and duplicate marker drop command does not harm to Redpanda. Changed log level of an entry notifying about duplicated drop command from an error to info level. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-error-topic-table
branch
from
25283e7
to
60e235f
Compare
ztlpn
previously approved these changes
Dec 15, 2023
mmaslankaprv
force-pushed
the
fix-error-topic-table
branch
from
bc310c3
to
60e235f
Compare
andrwng
approved these changes
Dec 15, 2023
|
/ci-repeat 1 |
|
/backport v23.2.x |
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the drop topic lifecycle marker replicate request would timeout. In this case requester has no other option than to retry dropping lifecycle marker. Logic in
cluster::topic_tableis idempotent and duplicate marker drop command does not harm to Redpanda. Changed log level of an entry notifying about duplicated drop command from an error to info level.Backports Required
Release Notes