Overrides for space_management_enable and retention_local_strict #15761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnwat
previously approved these changes
Dec 19, 2023
oleiman
requested review from
dotnwat and
mmaslankaprv
and removed request for
mmaslankaprv
mmaslankaprv
previously approved these changes
Dec 19, 2023
|
new failures in https://buildkite.com/redpanda/redpanda/builds/43037#018c8147-19ee-4987-8f3d-8a564f678cab: |
src/v/storage/disk_log_impl.cc
Outdated
Comment on lines
1013
to
1014
| !config::shard_local_cfg().retention_local_strict() | ||
| && !config::shard_local_cfg().retention_local_strict_override()) { |
There was a problem hiding this comment.
i think the test is failing as now we must set both properties if we do not want to use strict local retention, is that expected ?
There was a problem hiding this comment.
My mistake, I believe it should be one or the other.
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
oleiman
force-pushed
the
config-overrides
branch
from
48e671c
to
1385e73
Compare
|
force push to fix incorrect retention_local_strict_override condition |
dotnwat
approved these changes
Dec 19, 2023
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works around an issue where certain configs could be impossible to move durably off their legacy defaults after an upgrade by providing override config properties without legacy defaults (and with default values matching the legacy default value).
Fixes #15674
Backports Required
Release Notes
Bug Fixes