Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] Overrides for space_management_enable and retention_local_strict #15787

Merged
merged 2 commits into from
Dec 20, 2023
Merged

[v23.2.x] Overrides for space_management_enable and retention_local_strict #15787

merged 2 commits into from
Dec 20, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #15761
Fixes: #15786,

@oleiman @vbotbuildovich
config: Introduce retention_local_strict_override
72a08a1 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 159279d)
@oleiman @vbotbuildovich
config: Introduce space_management_enable_override
571df75 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 1385e73)
@vbotbuildovich vbotbuildovich added this to the v23.2.x-next milestone Dec 19, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Dec 19, 2023
@oleiman oleiman requested a review from dotnwat December 19, 2023 23:05
@oleiman oleiman marked this pull request as ready for review December 19, 2023 23:05
oleiman
oleiman approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-approving clean backport

@piyushredpanda
Copy link
Contributor

/dt

@oleiman
Copy link
Member

oleiman commented Dec 20, 2023

failed build looks to be a node shutdown timeout of some kind. not likely related to this, but let's retry to be sure.

@piyushredpanda
Copy link
Contributor

@oleiman : right and the other failure seems to be #14543; will merge.

@piyushredpanda piyushredpanda merged commit a1de7f6 into redpanda-data:v23.2.x Dec 20, 2023
22 of 24 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.2.x-next, v23.2.21 Dec 20, 2023
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiman oleiman oleiman approved these changes

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.2.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbotbuildovich @piyushredpanda @oleiman