Added metric representing bytes read from follower #15799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @tmgstevens |
ztlpn
reviewed
Dec 20, 2023
Since it is hard to validate if Follower Fetching feature is working correctly we add a separate `bytes_fetched_from_follower_total` metric that counts bytes that were read from the follower. This will make it very easy to validate if consumers are reading from the closest replica. Note: follower fetched bytes are also accounted to overall bytes read. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
ff-metric
branch
2 times, most recently
from
514a895
to
57d6bcc
Compare
Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
ff-metric
branch
from
57d6bcc
to
9d87132
Compare
ztlpn
approved these changes
Dec 20, 2023
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it is hard to validate if Follower Fetching feature is working
correctly we add a separate
bytes_fetched_from_follower_totalmetricthat counts bytes that were read from the follower. This will make it
very easy to validate if consumers are reading from the closest replica.
Note: follower fetched bytes are also accounted to overall bytes read.
Important note:
Follower fetched bytes may not be incremented if consumer closest replica is current partition leader.
Fixes: #14814
Backports Required
Release Notes
Improvements