[v23.3.x] Ext4 detection #15855
Merged
[v23.3.x] Ext4 detection #15855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print the detected filsystem type at info always, since this is critical one-time info. Also print the detected fs type in the warning message when the type is not xfs or ext4. (cherry picked from commit b6a869f)
Due to scylladb/seastar#251 all of ext2, ext3 and ext4 will be detected as ext2 (they shared the same superblock magic number). This leads to an erroneous warning claiming that you are not running on ext4 nor XFS. For now, we will simply that assume any ext detection means ext4, as ext2 and 3 use is very limited as ext4 was rolled out more than 15 years ago and almost entirely supplanted use of the earlier variants. In any case, the change only changes the warning message emitted, not any other behavior. Issue redpanda-data#13469. (cherry picked from commit 04168f2)
To make it clearer why we treat ext2 as ext4. (cherry picked from commit f99eb9e)
As pointed out in review. (cherry picked from commit 328c245)
We semi-support ext4 but in the syscheck we will now check for both ext2 and ext4, as currently ext4 is always detected as ext2, but in the future if ext4 is returned we should also treat this as ext4. Issue redpanda-data#13469. (cherry picked from commit 051c63c)
StephanDollberg
approved these changes
Dec 21, 2023
|
/ci-repeat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #13496