[v23.3.x] transform: create smp and scheduling groups #16139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass RPC requests by value, as we start to write some handlers using
coroutines, it can be a footgun to access have a suspension point, then
the request is destroyed. An example that motivated this:
```c++
ss::future<reply> service::handle(request&& r, rpc::streaming_context&) {
co_await ss::coroutine::switch_to(get_scheduling_group());
co_return co_await handle_request(std::move(r));
}
```
In this case `r` is destroyed because the coroutine does not own the
value, and handle request would have a stack-use-after-return issue.
Now that we pass by value, we don't have to remember to move the value
into the current method.
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
(cherry picked from commit 5becd89)
Add a scheduling group parameter for all the work executed on the queue. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 566e2b1)
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 4b3251b)
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 6928acc)
When RPCs come in for transform requests, ensure that they are running on the transform scheduling groups. Node local service requests are assumed to be already running on the transform scheduling group, which is mostly true except for deploys. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 895af5f)
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit d018c59)
The transform/rpc subsystem makes cross shard calls when accessing the correct partition for a transform, use a `smp_group` to manage this, like other subsystems. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit cb310c5)
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 99a3ece)
Correct the bot only failed because of conflicts in transform/rpc/service.cc because git incorrectly associated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16114
To get a clean backport I also cherry picked #15971 into this backport